[webkit-reviews] review granted: [Bug 151994] Light cleanup in TextPainter. : [Attachment 266894] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Dec 8 09:05:00 PST 2015
Darin Adler <darin at apple.com> has granted zalan <zalan at apple.com>'s request for
review:
Bug 151994: Light cleanup in TextPainter.
https://bugs.webkit.org/show_bug.cgi?id=151994
Attachment 266894: Patch
https://bugs.webkit.org/attachment.cgi?id=266894&action=review
--- Comment #2 from WebKit Commit Bot <commit-queue at webkit.org> ---
Attachment 266894 did not pass style-queue:
ERROR: Source/WebCore/rendering/TextPainter.cpp:86: Code inside a namespace
should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/TextPainter.cpp:86: Wrong number of spaces
before statement. (expected: 8) [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/TextPainter.cpp:87: Wrong number of spaces
before statement. (expected: 8) [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/TextPainter.cpp:88: Wrong number of spaces
before statement. (expected: 8) [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/TextPainter.cpp:89: Wrong number of spaces
before statement. (expected: 8) [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/TextPainter.cpp:90: Wrong number of spaces
before statement. (expected: 8) [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/TextPainter.cpp:91: Wrong number of spaces
before statement. (expected: 8) [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/TextPainter.cpp:92: Wrong number of spaces
before statement. (expected: 8) [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/TextPainter.cpp:93: Wrong number of spaces
before statement. (expected: 8) [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/TextPainter.cpp:94: Wrong number of spaces
before statement. (expected: 8) [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/TextPainter.cpp:95: Wrong number of spaces
before statement. (expected: 8) [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/TextPainter.cpp:96: Wrong number of spaces
before statement. (expected: 8) [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/TextPainter.cpp:97: Wrong number of spaces
before statement. (expected: 8) [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/TextPainter.cpp:98: Wrong number of spaces
before statement. (expected: 8) [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/TextPainter.cpp:99: Wrong number of spaces
before statement. (expected: 8) [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/TextPainter.cpp:100: Wrong number of spaces
before statement. (expected: 8) [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/TextPainter.cpp:101: Wrong number of spaces
before statement. (expected: 8) [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/TextPainter.cpp:102: Wrong number of spaces
before statement. (expected: 8) [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/TextPainter.cpp:103: Wrong number of spaces
before statement. (expected: 8) [whitespace/indent] [4]
Total errors found: 19 in 3 files
If any of these errors are false positives, please file a bug against
check-webkit-style.
More information about the webkit-reviews
mailing list