[webkit-reviews] review canceled: [Bug 147445] XHR.setRequestHeader should remove trailing and leading whitespaces from the header value : [Attachment 258719] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has canceled	review:
Bug 147445: XHR.setRequestHeader should remove trailing and leading whitespaces
from the header value
https://bugs.webkit.org/show_bug.cgi?id=147445

Attachment 258719: Patch

https://bugs.webkit.org/attachment.cgi?id=258719&action=review




--- Comment #30 from youenn fablet <youennf at gmail.com> ---
(In reply to comment #29)
> Comment on attachment 258719 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=258719&action=review
> 
> > Source/WebCore/xml/XMLHttpRequest.cpp:958
> > +	 String normalizedValue = stripLeadingAndTrailingHTTPSpaces(value);
> > +	 if (!isValidHTTPHeaderValue(normalizedValue)) {
> > +	     ec = SYNTAX_ERR;
> > +	     return;
> > +	 }
> 
> This changes the order of checking as well as changing the check. Why?
> 
> Also there is no test coverage for this change in order.

We check after normalization, following the spec.
I will revert the order change.