[webkit-reviews] review granted: [Bug 137270] Use is<>() / downcast<>() for ContainerNode : [Attachment 238964] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 30 15:25:39 PDT 2014
Andreas Kling <akling at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 137270: Use is<>() / downcast<>() for ContainerNode
https://bugs.webkit.org/show_bug.cgi?id=137270
Attachment 238964: Patch
https://bugs.webkit.org/attachment.cgi?id=238964&action=review
------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=238964&action=review
r=me
> Source/WebCore/dom/Node.h:-745
> -// FIXME: This should be removed and all uses should be replaced with
SPECIALIZE_TYPE_TRAITS_*().
> -#define NODE_TYPE_CASTS(ToClassName) \
> - TYPE_CASTS_BASE(ToClassName, Node, node,
WebCore::is##ToClassName(*node), WebCore::is##ToClassName(node))
Yay!
More information about the webkit-reviews
mailing list