[webkit-reviews] review granted: [Bug 137256] EWS doesn't need to show all the bubbles when a patch fails to apply : [Attachment 238941] proposed patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 137256: EWS doesn't need to show all the bubbles when a patch fails to
apply
https://bugs.webkit.org/show_bug.cgi?id=137256

Attachment 238941: proposed patch
https://bugs.webkit.org/attachment.cgi?id=238941&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=238941&action=review


> Tools/QueueStatusServer/app.yaml:2
> -version: 174192 # Bugzilla bug ID of last major change
> +version: ap # Bugzilla bug ID of last major change

Revert?

> Tools/QueueStatusServer/handlers/statusbubble.py:194
> -	   return (bubbles, show_submit_to_ews)
> +	   return (bubbles, show_submit_to_ews, failed_to_apply and not
had_output and not show_submit_to_ews)

I would have written this as:

failed_to_apply = any(map(lambda bubble: 'failed_to_apply' in bubble, bubbles)
had_output = all(map(lambda bubble: 'no_output_yet' in bubble, bubbles)
return (bubbles, show_submit_to_ews, failed_to_apply and not had_output)

instead of updating variables in the loop.  It's much easier to understand.