[webkit-reviews] review requested: [Bug 128177] [EFL] Switch to CUSTOM_PROTOCOLS : [Attachment 238932] Patch proposal to fix ewk_context_url_scheme_register() ewebkit2 API

[bugzilla-daemon at webkit.org]

Pascal Jacquemart <p.jacquemart at samsung.com> has asked	for review:
Bug 128177: [EFL] Switch to CUSTOM_PROTOCOLS
https://bugs.webkit.org/show_bug.cgi?id=128177

Attachment 238932: Patch proposal to fix ewk_context_url_scheme_register()
ewebkit2 API
https://bugs.webkit.org/attachment.cgi?id=238932&action=review

------- Additional Comments from Pascal Jacquemart <p.jacquemart at samsung.com>

Two remaining issues so far:

- Inside the scheme callback ewk_url_scheme_request_path_get(request) returns
an empty path ?!
  > It seems I messed up something with WKURLCopyPath() and eina strings, but
what?

- m_uriSchemeRequests map should be freed once the request is completed (or
cancelled)
  > GTK port is holding a reference to the WebKitWebContext inside each request
handle
  > Any other idea because I don't like this much?

All your comments so far would be very welcome