[webkit-reviews] review granted: [Bug 137193] [GTK] Move GtkPopupMenu implementation to WebPopupMenuProxyGtk : [Attachment 238812] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 137193: [GTK] Move GtkPopupMenu implementation to WebPopupMenuProxyGtk
https://bugs.webkit.org/show_bug.cgi?id=137193

Attachment 238812: Patch
https://bugs.webkit.org/attachment.cgi?id=238812&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=238812&action=review


LGTM with one question:

> Source/WebKit2/UIProcess/gtk/WebPopupMenuProxyGtk.cpp:-69
> -	   m_popup->clear();

Is clearing the menu no longer necessary? I couldn't figure out what change
makes this not needed.