[webkit-reviews] review granted: [Bug 137246] Avoid copying the iterated-over items in range-based for-loops in RenderGrid : [Attachment 238913] Patch

[bugzilla-daemon at webkit.org]

Sergio Villar Senin <svillar at igalia.com> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 137246: Avoid copying the iterated-over items in range-based for-loops in
RenderGrid
https://bugs.webkit.org/show_bug.cgi?id=137246

Attachment 238913: Patch
https://bugs.webkit.org/attachment.cgi?id=238913&action=review

------- Additional Comments from Sergio Villar Senin <svillar at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=238913&action=review


> Source/WebCore/ChangeLog:9
> +	of the items that are being iterated.

Something wrong with the indentation here

> Source/WebCore/rendering/RenderGrid.cpp:562
> +    for (auto& trackIndex : sizingData.contentSizedTracksIndex) {

This is just a size_t. I don't think we need this...