[webkit-reviews] review denied: [Bug 130967] erroneous date calculations on march 30, 2014 (CET/CEST time zone) the day on which daylight savings time changes : [Attachment 238894] Patch

[bugzilla-daemon at webkit.org]

José Dapena Paz <jdapena at igalia.com> has denied Byungseon Shin
<sun.shin at lge.com>'s request for review:
Bug 130967: erroneous date calculations on march 30, 2014 (CET/CEST time zone)
the day on which daylight savings time changes
https://bugs.webkit.org/show_bug.cgi?id=130967

Attachment 238894: Patch
https://bugs.webkit.org/attachment.cgi?id=238894&action=review

------- Additional Comments from José Dapena Paz <jdapena at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=238894&action=review


Could you detail, in the bug reported issue, the outcome after applying the
patch? I.e. what happens at new Date(2014, 3, 30, 2, 0) and new Data(2014, 3,
30, 2, 10)? Both cases getHours should return 3.

> LayoutTests/ChangeLog:9
> +	   DST starts at April 25, 1982 at 3:00 am, so it is correct to return
2:00 am.

The meaning of this is: DST starts at 3:00 am. So at 2am, it started to be 3am.
So it should return 3:00am PDT. The original test is right.

> LayoutTests/js/dom/script-tests/date-DST-time-cusps.js:12
> +    testCases.push(["(new Date(1982, 2, 14, 2)).getHours()", "2"]);

Original test was right. At 2am it became 3am, and DST started. So the right
outcome is 3.

> LayoutTests/js/dom/script-tests/date-DST-time-cusps.js:15
>  }

Likely a good idea would be adding new sets of tests for other timezones, so
build bots with different timezones would still exercise this.