[webkit-reviews] review denied: [Bug 137213] Minor bug in UIClient::exceededDatabaseQuota() : [Attachment 238853] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 29 13:12:04 PDT 2014


Anders Carlsson <andersca at apple.com> has denied JinYoung Hur
<hurims at gmail.com>'s request for review:
Bug 137213: Minor bug in UIClient::exceededDatabaseQuota()
https://bugs.webkit.org/show_bug.cgi?id=137213

Attachment 238853: Patch
https://bugs.webkit.org/attachment.cgi?id=238853&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=238853&action=review


> Source/WebKit2/ChangeLog:9
> +	   (WKPageSetPageUIClient):

Patch looks great, but please fill in the ChangeLog, saying something like:

"Make sure to not call the completion handler twice if exceededDatabaseQuota is
null."


More information about the webkit-reviews mailing list