[webkit-reviews] review granted: [Bug 137212] [GTK] [EFL] Install TestNetscapePlugin apart from the other libs to avoid scanning all of them on every test. : [Attachment 238854] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Carlos Alberto Lopez
Perez <clopez at igalia.com>'s request for review:
Bug 137212: [GTK] [EFL] Install TestNetscapePlugin apart from the other libs to
avoid scanning all of them on every test.
https://bugs.webkit.org/show_bug.cgi?id=137212

Attachment 238854: Patch
https://bugs.webkit.org/attachment.cgi?id=238854&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=238854&action=review


Thanks! Gyuyoung, is this ok for the EFL port?

> Tools/Scripts/webkitpy/port/efl.py:68
> -	   env['TEST_RUNNER_PLUGIN_PATH'] = self._build_path('lib')
> +	   env['TEST_RUNNER_PLUGIN_PATH'] = self._build_path('lib/plugins')

Nit: this should be self._build_path('lib', 'plugins') so that build_path can
use the appropriate dir separator on every platform. Not a big deal, since this
is only used in unix, but still.

> Tools/Scripts/webkitpy/port/gtk.py:113
> -	   environment['TEST_RUNNER_TEST_PLUGIN_PATH'] =
self._build_path('lib')
> +	   environment['TEST_RUNNER_TEST_PLUGIN_PATH'] =
self._build_path('lib/plugins')

Ditto.