[webkit-reviews] review granted: [Bug 136453] [CSS Grid Layout] Handle percentages of indefinite sizes in minmax() and grid-auto-* : [Attachment 237491] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 28 18:03:07 PDT 2014


Darin Adler <darin at apple.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 136453: [CSS Grid Layout] Handle percentages of indefinite sizes in
minmax() and grid-auto-*
https://bugs.webkit.org/show_bug.cgi?id=136453

Attachment 237491: Patch
https://bugs.webkit.org/attachment.cgi?id=237491&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237491&action=review


> Source/WebCore/rendering/RenderGrid.cpp:303
> +	   GridTrackSize trackSize = gridTrackSize(direction, i);

A return value of type GridTrackSize can go into a local variable of const
GridTrackSize& and gets an appropriate lifetime. So these changes, while OK,
are not needed.

> Source/WebCore/rendering/RenderGrid.cpp:471
> +    const Vector<GridTrackSize>& trackStyles =  isForColumns ?
style().gridColumns() : style().gridRows();

Seems like a good place to do auto&.

> Source/WebCore/rendering/RenderGrid.cpp:472
> +    const GridTrackSize& trackSize = (i >= trackStyles.size()) ?
(isForColumns ? style().gridAutoColumns() : style().gridAutoRows()) :
trackStyles[i];

Seems like a good place to do auto&.


More information about the webkit-reviews mailing list