[webkit-reviews] review granted: [Bug 137174] Automatically generate template specializations for most Elements : [Attachment 238781] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 28 17:27:44 PDT 2014


Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 137174: Automatically generate template specializations for most Elements
https://bugs.webkit.org/show_bug.cgi?id=137174

Attachment 238781: Patch
https://bugs.webkit.org/attachment.cgi?id=238781&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=238781&action=review


Looks great.

> Source/WebCore/svg/SVGAnimateElement.h:35
> +class SVGAnimateElementBase : public SVGAnimationElement {

I think we should consider moving SVGAnimateElementBase to its own separate
source file.


More information about the webkit-reviews mailing list