[webkit-reviews] review granted: [Bug 137197] Replace wkGetGlyphsForCharacters() with CGFontGetGlyphsForUnichars() : [Attachment 238824] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 137197: Replace wkGetGlyphsForCharacters() with
CGFontGetGlyphsForUnichars()
https://bugs.webkit.org/show_bug.cgi?id=137197

Attachment 238824: Patch
https://bugs.webkit.org/attachment.cgi?id=238824&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=238824&action=review


> Source/WebCore/platform/spi/cocoa/CGFontUnicodeSupport.h:30
> +#else

This should not be an else, we should forward declare functions
unconditionally. 

Also, I think the the file name should end with SPI by convention.