[webkit-reviews] review granted: [Bug 137156] HTMLPlugInElement::isUserObservable() is causing layout : [Attachment 238743] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 137156: HTMLPlugInElement::isUserObservable() is causing layout
https://bugs.webkit.org/show_bug.cgi?id=137156

Attachment 238743: Patch
https://bugs.webkit.org/attachment.cgi?id=238743&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=238743&action=review


> Source/WebCore/html/HTMLPlugInElement.h:54
> +    enum PluginLoadingPolicy  { PluginLoadingPolicyDoNotLoad,
PluginLoadingPolicyLoad };

I don't think there is a value in prefixing the enum value with
PluginLoadingPolicy.
If anything, use enum class instead.

> Source/WebCore/html/HTMLPlugInElement.h:55
> +    WEBCORE_EXPORT Widget* pluginWidget(PluginLoadingPolicy	=
PluginLoadingPolicyLoad) const;

Nit: Two spaces before =.