[webkit-reviews] review granted: [Bug 137158] Replace OSObjectPtr with RetainPtr/adoptOS : [Attachment 238740] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 26 16:24:06 PDT 2014


mitz at webkit.org <mitz at webkit.org> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 137158: Replace OSObjectPtr with RetainPtr/adoptOS
https://bugs.webkit.org/show_bug.cgi?id=137158

Attachment 238740: Patch
https://bugs.webkit.org/attachment.cgi?id=238740&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=238740&action=review


> Source/WTF/ChangeLog:15
> +	   in that unlike adoptCF(), it can be passed an objective-c type
(since OS objects
> +	   are sometimes objective-c objects, but not always), and unlike
adoptNS() it doesn't 
> +	   require us to jump through hoops to appease GC (since OS objects are
not objective-c

Objective-C


More information about the webkit-reviews mailing list