[webkit-reviews] review granted: [Bug 137032] Chaining multiple :nth-child() does not work properly : [Attachment 238685] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 26 16:12:44 PDT 2014


Gavin Barraclough <barraclough at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 137032: Chaining multiple :nth-child() does not work properly
https://bugs.webkit.org/show_bug.cgi?id=137032

Attachment 238685: Patch
https://bugs.webkit.org/attachment.cgi?id=238685&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=238685&action=review


> Source/WebCore/cssjit/SelectorCompiler.cpp:1768
> +	       if (m_registerAllocator.availableRegisterCount() > 1) {

Is this (plus twice below) "> 1" because we need to allocate more registers
below (e.g. "LocalRegister divisorRegister(m_registerAllocator);")
If so, perhaps it might simplify to just hoist the further register allocation
above this point?


More information about the webkit-reviews mailing list