[webkit-reviews] review granted: [Bug 137152] Web Inspector: Type Token View shows type information on hover when it shouldn't : [Attachment 238737] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 26 14:25:16 PDT 2014


Brian Burg <burg at cs.washington.edu> has granted Saam Barati
<saambarati1 at gmail.com>'s request for review:
Bug 137152: Web Inspector: Type Token View shows type information on hover when
it shouldn't
https://bugs.webkit.org/show_bug.cgi?id=137152

Attachment 238737: patch
https://bugs.webkit.org/attachment.cgi?id=238737&action=review

------- Additional Comments from Brian Burg <burg at cs.washington.edu>
View in context: https://bugs.webkit.org/attachment.cgi?id=238737&action=review


> Source/WebInspectorUI/UserInterface/Views/TypeTokenView.js:135
> +	   if (this._types.structures && this._types.structures.length >= 1)

I think you can drop the >= 1 here.


More information about the webkit-reviews mailing list