[webkit-reviews] review granted: [Bug 137118] Bump EFL version to 1.11.2 : [Attachment 238661] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 25 19:26:05 PDT 2014


Gyuyoung Kim <gyuyoung.kim at webkit.org> has granted Tibor Mészáros
<tmeszaros.u-szeged at partner.samsung.com>'s request for review:
Bug 137118: Bump EFL version to 1.11.2
https://bugs.webkit.org/show_bug.cgi?id=137118

Attachment 238661: Patch
https://bugs.webkit.org/attachment.cgi?id=238661&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=238661&action=review


LGTM

> Tools/ChangeLog:3
> +	   Bump EFL version to 1.11.2

Please add [EFL] prefix.

> Tools/ChangeLog:8
> +	   - Disable NEON for EFL build because the build system doesn't pass
the necessary -mfpu=neon flag to the compiler.

Looks like we don't use - in ChangeLog.


More information about the webkit-reviews mailing list