[webkit-reviews] review granted: [Bug 137129] EWS only repeats its cycle every two hours : [Attachment 238681] proposed fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 25 16:07:03 PDT 2014
Ryosuke Niwa <rniwa at webkit.org> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 137129: EWS only repeats its cycle every two hours
https://bugs.webkit.org/show_bug.cgi?id=137129
Attachment 238681: proposed fix
https://bugs.webkit.org/attachment.cgi?id=238681&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=238681&action=review
> Tools/QueueStatusServer/model/activeworkitems.py:85
> - two_hours_ago = time.mktime((now -
timedelta(minutes=120)).timetuple())
> + two_hours_ago = time.mktime((now -
work_item_lock_timeout).timetuple())
We should rename two_hours_ago to something like cutoff_time now that the
timeout is abstracted by a variable.
More information about the webkit-reviews
mailing list