[webkit-reviews] review granted: [Bug 137103] Use is<HTML*Element>() instead of isHTML*Element() - Part 2 : [Attachment 238663] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 25 15:02:41 PDT 2014
Benjamin Poulain <benjamin at webkit.org> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 137103: Use is<HTML*Element>() instead of isHTML*Element() - Part 2
https://bugs.webkit.org/show_bug.cgi?id=137103
Attachment 238663: Patch
https://bugs.webkit.org/attachment.cgi?id=238663&action=review
------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=238663&action=review
> Source/WebCore/css/CSSDefaultStyleSheets.cpp:65
> static inline bool elementCanUseSimpleDefaultStyle(Element* e)
The argument should be a reference.
"e" should be element.
> Source/WebCore/html/HTMLNameCollection.cpp:54
> + return is<HTMLImageElement>(element) || is<HTMLFormElement>(element) ||
element.hasTagName(appletTag)
I guess element.hasTagName(appletTag) is one of the special case?
More information about the webkit-reviews
mailing list