[webkit-reviews] review denied: [Bug 137116] [GTK] Add selection-changed signal to the WebKit2 API : [Attachment 238655] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has denied Tomas Popela
<tpopela at redhat.com>'s request for review:
Bug 137116: [GTK] Add selection-changed signal to the WebKit2 API
https://bugs.webkit.org/show_bug.cgi?id=137116

Attachment 238655: Patch
https://bugs.webkit.org/attachment.cgi?id=238655&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=238655&action=review


Thanks for the patch, but new API should include a unit test.

> Source/WebKit2/ChangeLog:9
> +	   Add the selection-changed signal into the WebKit2 GTK+ API. This
> +	   signal will be emitted everytime the selection in page is changed.

What's the use case? what does evo do when the selection changes?

> Source/WebKit2/ChangeLog:14
> +	   * WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
> +	   (didChangeSelection):
> +	   (webkit_web_page_class_init):
> +	   (webkitWebPageCreate):

Why do you need this in the web extensions API?

> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:289
> +	*/

Since: 2.8

> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:294
> +	   0, 0, 0,

0, nullptr, nullptr,