[webkit-reviews] review granted: [Bug 136945] ASSERTION FAILED: columnCount in WebCore::CSSParser::parseGridTemplateAreasRow : [Attachment 238652] Patch

[bugzilla-daemon at webkit.org]

Sergio Villar Senin <svillar at igalia.com> has granted Javier Fernandez
<jfernandez at igalia.com>'s request for review:
Bug 136945: ASSERTION FAILED: columnCount in
WebCore::CSSParser::parseGridTemplateAreasRow
https://bugs.webkit.org/show_bug.cgi?id=136945

Attachment 238652: Patch
https://bugs.webkit.org/attachment.cgi?id=238652&action=review

------- Additional Comments from Sergio Villar Senin <svillar at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=238652&action=review


> Source/WebCore/css/CSSParser.cpp:5571
> +    if (gridRowNames.isEmpty() || gridRowNames.containsOnlyWhitespace())

Does this cover also multiple whitespaces?

>
LayoutTests/fast/css-grid-layout/grid-template-areas-empty-string-crash-expecte
d.txt:1
> +crbug.com/412715 - ASSERTION FAILED: columnCount in
blink::CSSPropertyParser::parseGridTemplateAreasRow

Do not mention external bugs. Also remove the blink:: thing

>
LayoutTests/fast/css-grid-layout/grid-template-areas-empty-string-crash.html:27

> +<p>crbug.com/412715 - ASSERTION FAILED: columnCount in
blink::CSSPropertyParser::parseGridTemplateAreasRow</p>

Ditto.