[webkit-reviews] review denied: [Bug 63290] Stack overflow with enormous SVG filter : [Attachment 238630] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 63290: Stack overflow with enormous SVG filter
https://bugs.webkit.org/show_bug.cgi?id=63290

Attachment 238630: Patch
https://bugs.webkit.org/attachment.cgi?id=238630&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=238630&action=review


Looks good. Just some smaller snippets.

> Source/WebCore/platform/graphics/filters/FilterEffect.cpp:113
> +	   depth = std::max(depth, in->depthOfEffectInputs());

Just a little misunderstanding I suppose. Not the depth matters, but the amount
of effects matters. So just sum up all effects.

> Source/WebCore/rendering/svg/RenderSVGResourceFilter.h:90
> +    const unsigned s_maxCountOfInputEffects = 200; // maximum number of
input effects regardless whether they are connected to a filter's lastEffect or
not

Please use sentences as comments with periods. Move the comment a line up
before the constant. Also, can't it be static constant? You already use s_.