[webkit-reviews] review granted: [Bug 136895] [iOS] run-webkit-tests should support minor versions under devices and create a testing device under the right runtime : [Attachment 238565] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted David Farler
<dfarler at apple.com>'s request for review:
Bug 136895: [iOS] run-webkit-tests should support minor versions under devices
and create a testing device under the right runtime
https://bugs.webkit.org/show_bug.cgi?id=136895

Attachment 238565: Patch
https://bugs.webkit.org/attachment.cgi?id=238565&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=238565&action=review


r=me

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:403
> +	       options.device_type = iphone5 if options.architecture == 'x86'
else iphone5s

Is it 'x86' or 'i386' for the 32-bit arch?  Do we need to support both?  (We
should support both if x86 is also used.)

> Tools/Scripts/webkitpy/xcode/simulator.py:6
> +import logging
> +import os
>  import subprocess
>  import re
> +import itertools
> +import time

Nit: Alphabetize.

> Tools/Scripts/webkitpy/xcode/simulator.py:99
> +	   self.available = availability != 'unavailable'

Should the sense of this be reversed so that garbage values default to
unavailable?

    self.available = availability == 'available'