[webkit-reviews] review granted: [Bug 135120] Web Inspector: the inspector should live in its own process : [Attachment 238503] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 135120: Web Inspector: the inspector should live in its own process
https://bugs.webkit.org/show_bug.cgi?id=135120

Attachment 238503: Patch
https://bugs.webkit.org/attachment.cgi?id=238503&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=238503&action=review


> Source/WebCore/testing/Internals.cpp:1495
> +    m_frontendWindow.clear();

This should use = nullptr.

> Source/WebKit2/UIProcess/API/C/WKInspector.cpp:177
> -bool WKInspectorIsDebuggingJavaScript(WKInspectorRef inspectorRef)
> +bool WKInspectorIsDebuggingJavaScript(WKInspectorRef)

As discussed, these should move to WKDeprecatedFunctions.

> Source/WebKit2/UIProcess/WebInspectorProxy.cpp:359
> +    static std::once_flag onceFlag;
> +    static LazyNeverDestroyed<RefPtr<WebContext>> context;
> +
> +    std::call_once(onceFlag, [] {
> +	   WebContextConfiguration configuration;
> +	  
WebContext::applyPlatformSpecificConfigurationDefaults(configuration);
> +	   context.construct(WebContext::create(configuration));
> +	  
context.get()->setProcessModel(ProcessModelMultipleSecondaryProcesses);
> +    });

There's no need to put a smart pointer inside a LazyNeverDestroyed. This can
just be something like:

static WebContext* context;
if (!context) {
 /// initialize context
}

return *context;

> Source/WebKit2/WebProcess/WebPage/WebInspector.messages.in:25
> -messages -> WebInspector LegacyReceiver {
> +messages -> WebInspector {

Very nice!