[webkit-reviews] review requested: [Bug 137056] Add initial is<>() / downcast<>() support for any type of Nodes : [Attachment 238585] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has asked  for review:
Bug 137056: Add initial is<>() / downcast<>() support for any type of Nodes
https://bugs.webkit.org/show_bug.cgi?id=137056

Attachment 238585: Patch
https://bugs.webkit.org/attachment.cgi?id=238585&action=review

------- Additional Comments from Chris Dumez <cdumez at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=238585&action=review


> Source/WebCore/dom/DocumentFragment.h:55
> +DEFINE_TYPE_HELPERS_BEGIN(DocumentFragment)

The reason the macro has a BEGIN / END is so that isDocumentFragment() can be
private. We don't want to have both isDocumentFragment() and
is<DocumentFragment>().

> Source/WebCore/dom/Node.h:742
> +template <typename ExpectedType, typename ArgType>

This is all moved from Element.h

> Source/WebCore/html/HTMLMediaElement.h:918
> +struct NodeTypeCastTraits<const HTMLMediaElement, ArgType> {

These explicit specializations will go away once I use DEFINE_TYPE_HELPERS_*()
everywhere. I only ported 2 classes in this patch to minimize the size of the
change.