[webkit-reviews] review granted: [Bug 137015] Add support for is<HTML*Element>() for type checking : [Attachment 238513] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 137015: Add support for is<HTML*Element>() for type checking
https://bugs.webkit.org/show_bug.cgi?id=137015

Attachment 238513: Patch
https://bugs.webkit.org/attachment.cgi?id=238513&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=238513&action=review


rs=me

> Source/WebCore/dom/Element.h:679
> +// Type checking function for Elements, to use before casting
> +// with downcast<>().

This should be on a one line.

> Source/WebCore/dom/make_names.pl:647
> +    static bool checkTagName(const HTMLElement& element) { return
!element.isHTMLUnknownElement() &&
element.hasTagName($parameters{namespace}Names::${name}Tag); }

It's really a shame we need isHTMLUnknownElement(). It'd be nice if you find a
way to remove it.