[webkit-reviews] review granted: [Bug 137036] Have CSS classes' methods return more references : [Attachment 238573] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 137036: Have CSS classes' methods return more references
https://bugs.webkit.org/show_bug.cgi?id=137036

Attachment 238573: Patch
https://bugs.webkit.org/attachment.cgi?id=238573&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=238573&action=review


> Source/WebCore/inspector/InspectorStyleSheet.cpp:849
> -    RefPtr<CSSRuleSourceData> sourceData = ruleSourceDataFor(rule->style());

> +    RefPtr<CSSRuleSourceData> sourceData =
ruleSourceDataFor(&rule->style());

Can't we use Ref instead?

> Source/WebCore/inspector/InspectorStyleSheet.cpp:932
> -    RefPtr<CSSRuleSourceData> sourceData = ruleSourceDataFor(rule->style());

> +    RefPtr<CSSRuleSourceData> sourceData =
ruleSourceDataFor(&rule->style());

Ditto.