[webkit-reviews] review granted: [Bug 136714] AX: in an aria-labelledby computation, do not traverse into elements whose nameFrom value does not include 'contents' : [Attachment 238554] patch

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <mario at webkit.org> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 136714: AX: in an aria-labelledby computation, do not traverse into
elements whose nameFrom value does not include 'contents'
https://bugs.webkit.org/show_bug.cgi?id=136714

Attachment 238554: patch
https://bugs.webkit.org/attachment.cgi?id=238554&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=238554&action=review


> Source/WebCore/ChangeLog:19
> +2014-09-23  Chris Fleizach  <cfleizach at apple.com>
> +
> +	   AX: In an aria-labelledby computation, do not traverse into elements
whose nameFrom value does not include 'contents'
> +	   https://bugs.webkit.org/show_bug.cgi?id=136714
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   There are certain ARIA elements that tell us we should not query
their children when determining the name of the object.
> +	   Those ones have the "nameFrom" property set to "author" instead of
"contents." WebKit needs to honor that status.
> +
> +	   Modified: accessibility/aria-labelledby-with-descendants.html
> +
> +	   * accessibility/AccessibilityNodeObject.cpp:
> +	   (WebCore::shouldUseAccessiblityObjectInnerText):
> +	   (WebCore::accessibleNameForNode):
> +	   * accessibility/AccessibilityObject.cpp:
> +	   (WebCore::AccessibilityObject::accessibleNameDerivesFromContent):
> +	   * accessibility/AccessibilityObject.h:
> +

This chunk seems to be duplicated in the patch (yet probably harmless)