[webkit-reviews] review granted: [Bug 135774] Implement snapping behavior for Mac overflow scrolling : [Attachment 238569] Updated the patch to build cleanly on current ToT (and iOS).

[bugzilla-daemon at webkit.org]

Beth Dakin <bdakin at apple.com> has granted Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 135774: Implement snapping behavior for Mac overflow scrolling
https://bugs.webkit.org/show_bug.cgi?id=135774

Attachment 238569: Updated the patch to build cleanly on current ToT (and iOS).
https://bugs.webkit.org/attachment.cgi?id=238569&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=238569&action=review


> Source/WebCore/platform/ScrollAnimator.cpp:41
> +#if ENABLE(CSS_SCROLL_SNAP) && PLATFORM(MAC)

This include should not be necessary since Timer.h is included from the header.


> Source/WebCore/platform/ScrollAnimator.h:42
> +#include "Timer.h"

Is it necessary to include Timer.h in this header? I know I previously said to
remove the include from the implementation file, and that should be done if
this is necessary. But if this is not necessary, it should be removed, and the
implementation file's include should be maintained.