[webkit-reviews] review granted: [Bug 136955] Web Inspector: Remove UserInterface/Images/gtk from Apple builds : [Attachment 238564] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 136955: Web Inspector: Remove UserInterface/Images/gtk from Apple builds
https://bugs.webkit.org/show_bug.cgi?id=136955

Attachment 238564: Patch
https://bugs.webkit.org/attachment.cgi?id=238564&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=238564&action=review


r=me

> Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl:185
> +    remove_tree(File::Spec->catdir($targetResourcePath, 'Images', 'gtk')) if
defined $ENV{'MAC_OS_X_VERSION_MAJOR'} or defined $ENV{'OFFICIAL_BUILD'};

I feel like it would be cleaner if we checked some ENV variable like:

    export OS=MACOS
    export PLATFORM_NAME=macosx

But, I'm not sure what other OSes have set for their ENV variables when running
this build phase so this is probably fine.