[webkit-reviews] review granted: [Bug 137031] [Tools] git-commit uses wrong ChangeLog when run from a subdirectory : [Attachment 238548] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 23 13:10:41 PDT 2014


Joseph Pecoraro <joepeck at webkit.org> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 137031: [Tools] git-commit uses wrong ChangeLog when run from a
subdirectory
https://bugs.webkit.org/show_bug.cgi?id=137031

Attachment 238548: Patch
https://bugs.webkit.org/attachment.cgi?id=238548&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=238548&action=review


r=me!

> Tools/Scripts/commit-log-editor:155
> + at changeLogs = map { $ENV{GIT_PREFIX} . $_} @changeLogs if (isGit());

Nit: Should have a space at the end of the inside block
Nit: Unnecessary parens around the if condition when it is at the end of the
line:

    @changeLogs = map { $ENV{GIT_PREFIX} . $_ } @changeLogs if isGit();


More information about the webkit-reviews mailing list