[webkit-reviews] review granted: [Bug 137008] [WebKit2] Add UI delegate callback when window.close() is called : [Attachment 238492] Patch and unit test

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 137008: [WebKit2] Add UI delegate callback when window.close() is called
https://bugs.webkit.org/show_bug.cgi?id=137008

Attachment 238492: Patch and unit test
https://bugs.webkit.org/attachment.cgi?id=238492&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=238492&action=review


> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:70
> +   
webView.get().configuration.preferences.javaScriptCanOpenWindowsAutomatically =
YES;

Please use [webView configuration].preferences here instead