[webkit-reviews] review denied: [Bug 136850] W3C test importer should copy .htaccess files : [Attachment 238171] Patch

[bugzilla-daemon at webkit.org]

Bem Jones-Bey <bjonesbe at adobe.com> has denied youenn fablet
<youennf at gmail.com>'s request for review:
Bug 136850: W3C test importer should copy .htaccess files
https://bugs.webkit.org/show_bug.cgi?id=136850

Attachment 238171: Patch
https://bugs.webkit.org/attachment.cgi?id=238171&action=review

------- Additional Comments from Bem Jones-Bey <bjonesbe at adobe.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=238171&action=review


> Tools/Scripts/webkitpy/w3c/test_importer.py:184
>		   if filename.startswith('.') or filename.endswith('.pl'):
> -		       continue  # For some reason the w3c repo contains random
perl scripts we don't care about.
> +		       if not filename == '.htaccess':
> +			   continue  # For some reason the w3c repo contains
random perl scripts we don't care about.

This is getting messy. I would add a helper like should_skip_file(), and move
all of the tests there. Then this would be something like:
if self.should_skip_file(filename):
  continue