[webkit-reviews] review granted: [Bug 133320] [GTK] Adds implementation of subtle crypto HMAC algorithm : [Attachment 236507] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 22 02:20:27 PDT 2014


Philippe Normand <pnormand at igalia.com> has granted Eduardo Lima Mitev
<elima at igalia.com>'s request for review:
Bug 133320: [GTK] Adds implementation of subtle crypto HMAC algorithm
https://bugs.webkit.org/show_bug.cgi?id=133320

Attachment 236507: Patch
https://bugs.webkit.org/attachment.cgi?id=236507&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=236507&action=review


Looks good! Only a small nit to fix, I think

> Source/WebCore/crypto/gtk/CryptoAlgorithmHMACGtk.cpp:99
> +    callback(result);}

Is this a spurious curly brace?


More information about the webkit-reviews mailing list