[webkit-reviews] review granted: [Bug 136991] Update HTMLMediaElement logging : [Attachment 238443] Proposed patch.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Sep 21 18:57:14 PDT 2014
Alexey Proskuryakov <ap at webkit.org> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 136991: Update HTMLMediaElement logging
https://bugs.webkit.org/show_bug.cgi?id=136991
Attachment 238443: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=238443&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=238443&action=review
> Source/WebCore/html/HTMLMediaElement.cpp:673
> + LOG(Media, "HTMLMediaElement::removedFrom(%p)", this);
I'd log this as HTMLMediaElement %p removedFrom", to make it clear that it's
not an argument. Ditto elsewhere.
More information about the webkit-reviews
mailing list