[webkit-reviews] review granted: [Bug 136983] Structure should have a method for concurrently getting all of the property map entries, and this method shouldn't involve copy-paste : [Attachment 238431] the patch

[bugzilla-daemon at webkit.org]

Mark Hahnenberg <mhahnenb at gmail.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 136983: Structure should have a method for concurrently getting all of the
property map entries, and this method shouldn't involve copy-paste
https://bugs.webkit.org/show_bug.cgi?id=136983

Attachment 238431: the patch
https://bugs.webkit.org/attachment.cgi?id=238431&action=review

------- Additional Comments from Mark Hahnenberg <mhahnenb at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=238431&action=review


r=me with comments.

> Source/JavaScriptCore/runtime/Structure.h:76
> +struct PropertyMapEntry {

Maybe it makes sense to just pull this into its own header? It seems sort of
weird to move it to Structure.h from PropertyMapHashTable.h.

> Source/JavaScriptCore/runtime/StructureInlines.h:117
> +	   for (auto entry : *table) {

auto& maybe? Do we want to copy each entry as we're iterating?