[webkit-reviews] review denied: [Bug 136981] ArgumentEncoder::encode does not support long long : [Attachment 238421] A simple patch to fix the build failure

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 21 12:18:10 PDT 2014


Alexey Proskuryakov <ap at webkit.org> has denied	review:
Bug 136981: ArgumentEncoder::encode does not support long long
https://bugs.webkit.org/show_bug.cgi?id=136981

Attachment 238421: A simple patch to fix the build failure
https://bugs.webkit.org/attachment.cgi?id=238421&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
This is not the right way to fix the build failure. IPC should use fixed size
types.

What C++ library are you using? It seems to be buggy or obsolete,
std::chrono::milliseconds is of type std::chrono::duration, not a long long.


More information about the webkit-reviews mailing list