[webkit-reviews] review granted: [Bug 136943] [GTK] generate-inspector-gresource-manifest.py should receive the list of files from the makefile : [Attachment 238361] Try to make style checker happy

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 19 02:14:45 PDT 2014


Philippe Normand <pnormand at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 136943: [GTK] generate-inspector-gresource-manifest.py should receive the
list of files from the makefile
https://bugs.webkit.org/show_bug.cgi?id=136943

Attachment 238361: Try to make style checker happy
https://bugs.webkit.org/attachment.cgi?id=238361&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=238361&action=review


> Source/WebKit2/PlatformGTK.cmake:500
> +    COMMAND ${TOOLS_DIR}/gtk/generate-inspector-gresource-manifest.py
--output=${DERIVED_SOURCES_WEBKIT2GTK_DIR}/InspectorGResourceBundle.xml
${InspectorFiles}

The new risk here is to exceed command line length limits, I suppose it's ok
for now though.


More information about the webkit-reviews mailing list