[webkit-reviews] review granted: [Bug 136925] [iOS] Always enable on Production builds ENABLE_TOUCH_EVENTS, ENABLE_IOS_{TOUCH, GESTURE}_EVENTS, and ENABLE_XSLT : [Attachment 238328] Alternative Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org <mitz at webkit.org> has granted  review:
Bug 136925: [iOS] Always enable on Production builds ENABLE_TOUCH_EVENTS,
ENABLE_IOS_{TOUCH, GESTURE}_EVENTS, and ENABLE_XSLT
https://bugs.webkit.org/show_bug.cgi?id=136925

Attachment 238328: Alternative Patch
https://bugs.webkit.org/attachment.cgi?id=238328&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=238328&action=review


> Source/JavaScriptCore/Configurations/Base.xcconfig:31
> +USE_INTERNAL_SDK = $(USE_INTERNAL_SDK_$(CONFIGURATION));
> +USE_INTERNAL_SDK_Production = YES;
> +USE_INTERNAL_SDK_Debug = $(USE_INTERNAL_SDK_Debug_or_Release);
> +USE_INTERNAL_SDK_Release = $(USE_INTERNAL_SDK_Debug_or_Release);
> +USE_INTERNAL_SDK_Debug_or_Release = $(HAVE_INTERNAL_SDK);

Not sure the extra level of indirection is helping here. Simply defining
USE_INTERNAL_SDK_Debug and USE_INTERNAL_SDK_Release directly in terms of
HAVE_INTERNAL_SDK would have worked as well.