[webkit-reviews] review granted: [Bug 136929] ASSERT in RenderBox::instrinsicScrollbarLogicalWidth opening the inspector : [Attachment 238323] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 136929: ASSERT in RenderBox::instrinsicScrollbarLogicalWidth opening the
inspector
https://bugs.webkit.org/show_bug.cgi?id=136929

Attachment 238323: Patch
https://bugs.webkit.org/attachment.cgi?id=238323&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=238323&action=review


> Source/WebCore/ChangeLog:14
> +	   change, overflow:scroll elements would always, universally create
scrollbars 
> +	   regardless of whether or not there was content to scroll to. But
that was a very 
> +	   silly thing to do in the overlay scrollbar case, so we stopped doing
it, and 
> +	   reaped various benefits outlined in that bug as a result. This code
is wrong in 
> +	   our brave new world because it assumes that overflow:scroll will
always have a 
> +	   scrollbar. That is no longer the case. We need to check to make sure
it’s an 

I think you could say less about what r173668 did.