[webkit-reviews] review granted: [Bug 136870] Improve fullscreen video rotation animation. : [Attachment 238318] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 136870: Improve fullscreen video rotation animation.
https://bugs.webkit.org/show_bug.cgi?id=136870

Attachment 238318: Patch
https://bugs.webkit.org/attachment.cgi?id=238318&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=238318&action=review


> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:540
> +    if (animationDuration == 0.0) // a duration of 0 for CA means 0.25. This
is a way to approximate 0.

We normally write this as if (!animationDuration)