[webkit-reviews] review granted: [Bug 136923] [GTK] Dot not allow to create delete-on-destroy GMainLoopSources : [Attachment 238310] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 136923: [GTK] Dot not allow to create delete-on-destroy GMainLoopSources
https://bugs.webkit.org/show_bug.cgi?id=136923

Attachment 238310: Patch
https://bugs.webkit.org/attachment.cgi?id=238310&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=238310&action=review


> Source/WTF/wtf/gobject/GMainLoopSource.cpp:36
> -GMainLoopSource& GMainLoopSource::createAndDeleteOnDestroy()
> +GMainLoopSource& GMainLoopSource::create()

I think this name should be kept, otherwise it may lead people to believe that
this is the default or only way of creating, like on other objects, it gets
confusing.

> Source/WTF/wtf/gobject/GMainLoopSource.cpp:-85
> -    // Delete-on-destroy GMainLoopSource objects can only be cancelled when
there's callback either scheduled
> -    // or in the middle of dispatch. At that point cancellation will have no
effect.
> -    ASSERT(m_deleteOnDestroy != DeleteOnDestroy || (m_status == Ready &&
!m_context.source));

Heh, this was a bit weird.