[webkit-reviews] review canceled: [Bug 136906] CSS JIT: The backtracking register can be ignored from the minimumRegisterRequirements : [Attachment 238286] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 17 23:36:35 PDT 2014


Benjamin Poulain <benjamin at webkit.org> has canceled Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 136906: CSS JIT: The backtracking register can be ignored from the
minimumRegisterRequirements
https://bugs.webkit.org/show_bug.cgi?id=136906

Attachment 238286: Patch
https://bugs.webkit.org/attachment.cgi?id=238286&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=238286&action=review


>> Source/WebCore/cssjit/SelectorCompiler.cpp:859
>> +	    minimum += minimumRequiredRegisterCount;
> 
> I think it would be `+= backtrackingRegisterRequirements`. Is it correct?

Arg, ffs. I did a last minute change and I messed up the copy-paste.

I am glad I asked you for a review.


More information about the webkit-reviews mailing list