[webkit-reviews] review granted: [Bug 136870] Improve fullscreen video rotation animation. : [Attachment 238283] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 136870: Improve fullscreen video rotation animation.
https://bugs.webkit.org/show_bug.cgi?id=136870

Attachment 238283: Patch
https://bugs.webkit.org/attachment.cgi?id=238283&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=238283&action=review


> Source/WebKit2/Platform/mac/LayerHostingContext.mm:41
> + at interface CAContext : NSObject (Details)
> +- (void)invalidate;
> + at property (readonly) uint32_t contextId;
> + at property (strong) CALayer *layer;
> + at property CGColorSpaceRef colorSpace;
> +- (void)setFencePort:(mach_port_t)port;
>  + (CAContext *)remoteContextWithOptions:(NSDictionary *)dict;
>  @end

This should really go into its own spi header, but that can happen in a later
commit.

> Source/WebKit2/Platform/mac/LayerHostingContext.mm:88
> +    return [m_context setLayer:rootLayer];

No return.

> Source/WebKit2/Platform/mac/LayerHostingContext.mm:104
> +    return [m_context invalidate];

No return.

> Source/WebKit2/Platform/mac/LayerHostingContext.mm:109
> +    return [m_context setColorSpace:colorSpace];

No return.