[webkit-reviews] review granted: [Bug 136870] Improve fullscreen video rotation animation. : [Attachment 238263] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 136870: Improve fullscreen video rotation animation.
https://bugs.webkit.org/show_bug.cgi?id=136870

Attachment 238263: Patch
https://bugs.webkit.org/attachment.cgi?id=238263&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=238263&action=review


> Source/WebKit2/Platform/mac/LayerHostingContext.mm:51
> +    layerHostingContext->m_context =
(CAContext*)WKCAContextMakeRemoteWithServerPort(serverPort);

CAContext *

> Source/WebKit2/Platform/mac/LayerHostingContext.mm:86
> +    return [m_context setLayer:rootLayer];

no return.

> Source/WebKit2/Platform/mac/LayerHostingContext.mm:102
> +    return [m_context invalidate];

no return

> Source/WebKit2/Platform/mac/LayerHostingContext.mm:107
> +    return [m_context setColorSpace:colorSpace];

no return

> Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.mm:37
> +#include <UIKit/UIWindow_Private.h>

This will annoy dbates who is trying to make us build with the public SDK. You
should do the platform/spi thing.