[webkit-reviews] review granted: [Bug 136791] Mac queue slaves should reboot every so often : [Attachment 238210] Reboot between 1am and 6am

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 136791: Mac queue slaves should reboot every so often
https://bugs.webkit.org/show_bug.cgi?id=136791

Attachment 238210: Reboot between 1am and 6am
https://bugs.webkit.org/attachment.cgi?id=238210&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=238210&action=review


> Tools/ChangeLog:8
> +	   Reboot Mac queue slaves every 12 hours between 1 A.M. and 6 A.M.

The end result would be closer to every 24 hours than every 12 hours, wouldn't
it? I'd just say "every night between 1am and 6am".

> Tools/EWSTools/start-queue-mac.sh:41
> +TIME_TO_REBOOT=$(( $(date +%s) + 3600 * 12)) # Reboot every 12 hours between
1am and 6am.

Perhaps a "why" comment would help here (we only want to reboot at night to
reduce the likelihood of confusing unexpected things happening while people are
looking).