[webkit-reviews] review granted: [Bug 136849] [GTK] Add a helper class for display system deduction : [Attachment 238211] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 136849: [GTK] Add a helper class for display system deduction
https://bugs.webkit.org/show_bug.cgi?id=136849

Attachment 238211: Patch
https://bugs.webkit.org/attachment.cgi?id=238211&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=238211&action=review


>>> Source/WebCore/platform/gtk/GtkUtilities.cpp:67
>>> +	 static DisplaySystemType type = [] {
>> 
>> This version simplifies ('simplifies') the initialization by using a lambda.
This enables a properly applied ASSERT_NOT_REACHED() at the bottom of the
labmda.
> 
> Plus there's no need for the is-this-static-var-initialized-yet check.

Does that actually delay the execution of the code until the first call? If so,
that's pretty awesome.