[webkit-reviews] review granted: [Bug 136866] Exclude page visibility from PageThrottler's hysteresis : [Attachment 238205] Fix

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 136866: Exclude page visibility from PageThrottler's hysteresis
https://bugs.webkit.org/show_bug.cgi?id=136866

Attachment 238205: Fix
https://bugs.webkit.org/attachment.cgi?id=238205&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=238205&action=review


r=me

> Source/WebCore/page/PageThrottler.cpp:78
> +    // Allow throttling if there is no page activity, and the page is viibly
idle.

"visually"

> Source/WebCore/platform/HysteresisActivity.h:37
> +    Waiting,

I wonder if "Waiting" would be clearer if it said what it was waiting for.
Maybe "WaitingToStop" or "WillStop" "WillStopAfterDelay" or "WillStopSoon".