[webkit-reviews] review granted: [Bug 136860] Local OSR availability calculation should be reusable : [Attachment 238190] the patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 136860: Local OSR availability calculation should be reusable
https://bugs.webkit.org/show_bug.cgi?id=136860

Attachment 238190: the patch
https://bugs.webkit.org/attachment.cgi?id=238190&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=238190&action=review


r=me with the reference change

> Source/JavaScriptCore/ChangeLog:19
> +	   This reduces the amount of style points one could conceivably get in
the future when
> +	   hacking JSC, but creating a single reusable thingy for computing
local OSR availability.

The last half of this sentence doesn't seem to make sense - early finish?

> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:6747
> +    Operands<Availability> availability() { return
m_availabilityCalculator.m_availability; }
> +    

const Operands<Availability>&